feat: improve scroll syncing #21622
Merged
feat: improve scroll syncing #21622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.01 MB ℹ️ View Unchanged
|
pauldambra
reviewed
Apr 19, 2024
| @@ -161,12 +159,12 @@ export function PlayerInspectorList(): JSX.Element { | |||
| .getElementById('PlayerInspectorListMarker') | |||
| ?.setAttribute('style', `transform: translateY(${offset}px)`) | |||
|
|
|||
| if (!syncScrollingPaused && syncScroll) { | |||
| if (!syncScrollPaused) { | |||
There was a problem hiding this comment.
should syncSrollPaused and listRef be dependencies of the useEffect?
(more a "teach me" question than anything else :)
pauldambra
reviewed
Apr 19, 2024
| if (listRef.current) { | ||
| listRef.current.scrollToRow(playbackIndicatorIndex) | ||
| } | ||
| // Tricky: Need to dely to make sure the row scrolled has finished |
There was a problem hiding this comment.
Suggested change
| // Tricky: Need to dely to make sure the row scrolled has finished | |
| // Tricky: Need to delay to make sure the row scrolled has finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Before we had some complicated logic around when the scroll was synced
Towards #21302
Changes